This repository has been archived by the owner on Jan 6, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 72
fix: improve fullscreen mode #217
Open
OneGIl
wants to merge
7
commits into
webfansplz:main
Choose a base branch
from
OneGIl:fix/fullsreen-mode
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f532052
fix: "Exit Fullscreen" button is invalid
OneGIl 7ed5045
fix: disabled resize in non "default" view mode
OneGIl 2b275f7
fix: set correct anchor position in fullscreen
OneGIl f836c07
fix: edge case
OneGIl 0846d5f
chore: extracted "props.viewMode === 'default'"
OneGIl 983717e
chore: remove setTimeout and fix typo
OneGIl 074a18c
fix: correct mode when restoring panel from sx
OneGIl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,6 +14,7 @@ interface DevToolsFrameState { | |
isFirstVisit: boolean | ||
closeOnOutsideClick: boolean | ||
minimizePanelInactive: number | ||
viewMode: ViewMode | ||
} | ||
|
||
interface ComponentInspectorBounds { | ||
|
@@ -41,6 +42,7 @@ export const state = useObjectStorage<DevToolsFrameState>('__vue-devtools-frame- | |
isFirstVisit: true, | ||
closeOnOutsideClick: false, | ||
minimizePanelInactive: 5000, | ||
viewMode: 'default', | ||
}) | ||
|
||
// ---- useIframe ---- | ||
|
@@ -501,6 +503,29 @@ export function usePosition(panelEl: Ref<HTMLElement | undefined>) { | |
} | ||
} | ||
|
||
// ---- usePanelState ---- | ||
export function usePanelState() { | ||
const viewMode = computed({ | ||
get() { | ||
return state.value.viewMode | ||
}, | ||
set(value) { | ||
state.value.viewMode = value | ||
}, | ||
}) | ||
let perViewMode = viewMode.value | ||
|
||
function toggleViewMode(mode: ViewMode) { | ||
const newMode = mode ?? perViewMode | ||
setTimeout(() => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 这里使用setTimeout是因为在eyedropper里close方法里会同时修改client和node中的frameState,这会赋给viewMode错误的值。暂时没找到合适的解决方法。所以在这里用了setTimeout。 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 可以针对 eyeDropper 这种 viewMode 是 xs 的单独写一个判断逻辑 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 感谢建议,这部分我会再考虑一下~ |
||
perViewMode = viewMode.value | ||
viewMode.value = newMode | ||
}, 0) | ||
} | ||
|
||
return { viewMode, toggleViewMode } | ||
} | ||
|
||
// ---- useHighlightComponent ---- | ||
|
||
export function useHighlightComponent() { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
preViewMode? Looks like a typo here.