Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add local properties #1

Closed
wants to merge 4 commits into from
Closed

Add local properties #1

wants to merge 4 commits into from

Conversation

jmolivas
Copy link

@jmolivas jmolivas commented Nov 9, 2016

  • Add drupalRoot and projectRoot local scope properties.
  • Make sure isValidRoot returns a boolean.
  • Add getters for local properties.

NOTE: Not too happy with projectRoot maybe composerRoot will be better

Usage instructions:

use DrupalFinder\DrupalFinder;

$drupalFinder = new DrupalFinder();
$drupalFinder->locateRoot(‘path/to/drupal');
$drupalRoot = $drupalFinder->getDrupalRoot();
$projectRoot = $drupalFinder->getProjectRoot();

@webflo
Copy link
Owner

webflo commented Nov 9, 2016

👍 in genernal. Lets rename projectRoot to composerRoot and document what drupalRoot and composerRoot actually mean.

@jmolivas
Copy link
Author

@webflo updated

webflo added a commit that referenced this pull request Nov 10, 2016
@webflo
Copy link
Owner

webflo commented Nov 10, 2016

Thanks. I wrote some tests in #2 and squashed everything in 447d920

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants