Add wgpuAdapterRequestAdapterInfo #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beaufortfrancois
force-pushed
the
patch-4
branch
from
02b681a to
bbac47a
Compare
kainino0x
reviewed
Feb 8, 2024
There was a problem hiding this comment.
Hm, I forgot we also wanted to remove wgpuAdapterGetProperties.
I also forgot WGPUAdapterProperties has extra info in it.
We'll need a proposal, I'm not sure if we want to move the extra info to an extension of WGPUAdapterInfo (how?) or keep GetProperties for this extra info (but as a native-only extension with no implementation in Emscripten)
kainino0x
approved these changes
Feb 8, 2024
kainino0x
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed #266 (comment), this PR adds WGPUAdapterRequestAdapterInfo.