Some mobile browsers require playsInline to be set to true for the video #443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @kainino0x @greggman @beaufortfrancois who recently modified this file, are you ok with this change? |
|
LGTM overall. |
to play with the rest of the content. To avoid WebGPU samples testing differences between mobile and desktop browsers, set playsInline = true prior to playing the video.
mwyrzykowski
force-pushed
the
mike_w_set_plays_inline_for_mobile_browsers
branch
from
2b3c0f6 to
72de844
Compare
Sure let's update the other occurrence too even though I agree, it seems unused. |
kainino0x
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some mobile browsers require playsInline to be set to true for the video to play with the rest of the content.
To avoid WebGPU samples testing differences between mobile and desktop browsers, set playsInline = true prior to playing the video.