Use transparency in helloTriangle*, remove alphaMode on rest #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
None of the samples used transparent canvases, so they shouldn't set alphaMode.
toji
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
I think it's a good idea to take the alphaMode off of the majority of the samples, but I feel like we could use a slightly better demonstration of transparent canvases than the hello triangles? As-is it would be difficult to tell that they are transparent vs. simply clearing to a color that matches the background.
I'd prefer to have a sample that shows some DOM content (even just simple text) behind the canvas. Happy to help build it!
In the meantime, I think this can land as-is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
None of the samples used transparent canvases, so they shouldn't set alphaMode.
We should demonstrate transparent canvases though, so I made the two helloTriangle samples do that.
Technically opaque canvases force an alpha clear on Mac, but probably we should stick to the spec default. Someday maybe we can do something about that alpha clear.