Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility Mode, the easy part. #488

Merged
merged 3 commits into from
Jan 17, 2025
Merged

Conversation

SenorBlanco
Copy link
Collaborator

Enable WebGPU Compatibility Mode for all samples that can run unmodified in that mode.

Enable WebGPU Compatibility Mode for all samples that can run
unmodified in that mode.
@toji
Copy link
Contributor

toji commented Jan 17, 2025

Change looks fine, but I wanted to confirm the expected behavior:

  • For devices that only support compat mode this change will enable the sample to work where it didn't before.
  • For devices that support core WebGPU this flag will effectively be a no-op, even if the browser supports compat mode.
  • For browsers that do not implement compat mode this flag will be ignored.

Correct? If so, LGTM!

@kainino0x
Copy link
Collaborator

  • For devices that support core WebGPU this flag will effectively be a no-op, even if the browser supports compat mode.

The sample will start getting using a compat (but d3d12/vulkana/metal) device in this case, but since the samples don't use any compat features it doesn't have an effect except for a little extra runtime validation

Copy link
Contributor

@toji toji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the clarification, Kai! LGTM, I just wanted to ensure this wasn't going to inadvertently downgrade the adapters for these samples.

@toji toji merged commit 0ce1ef2 into webgpu:main Jan 17, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants