Remove admin queue tests (#123)

webgriffe · Jun 13, 2022 · 705db30 · 705db30
1 parent f79e61c
commit 705db30
Show file tree

Hide file tree

Showing 10 changed files with 7 additions and 174 deletions.
diff --git a/features/enqueuing_products.feature b/features/enqueuing_products.feature
@@ -40,7 +40,6 @@ Feature: Enqueuing products
     When I browse products
     And I schedule an Akeneo PIM import for the "Braided hat m" product
     Then I should be notified that it has been successfully enqueued
-    And I should see 1, not imported, item in the Akeneo queue items list
 
   @ui
   Scenario: Enqueuing a product already enqueued
@@ -50,7 +49,6 @@ Feature: Enqueuing products
     When I browse products
     And I schedule an Akeneo PIM import for the "Braided hat l" product
     Then I should be notified that it has been already enqueued
-    And I should see 1, not imported, item in the Akeneo queue items list
 
   @ui
   Scenario: Enqueuing a configurable product
@@ -61,4 +59,3 @@ Feature: Enqueuing products
     When I browse products
     And I schedule an Akeneo PIM import for the "Braided hat" product
     Then I should be notified that it has been successfully enqueued
-    And I should see 3, not imported, items in the Akeneo queue items list
diff --git a/features/managing_queue_items/browsing_queue_items.feature b/features/managing_queue_items/browsing_queue_items.feature
diff --git a/features/managing_queue_items/deleting_queue_items.feature b/features/managing_queue_items/deleting_queue_items.feature
diff --git a/src/Menu/AdminMenuListener.php b/src/Menu/AdminMenuListener.php
diff --git a/src/Resources/config/services.xml b/src/Resources/config/services.xml
@@ -69,10 +69,6 @@
             <tag name="kernel.event_subscriber" />
         </service>
 
-        <service id="webgriffe_sylius_akeneo.event_listener.admin_menu_listener" class="Webgriffe\SyliusAkeneoPlugin\Menu\AdminMenuListener">
-            <tag name="kernel.event_listener" event="sylius.menu.admin.main" method="addAdminMenuItems" />
-        </service>
-
         <!-- Product Importer -->
         <service id="webgriffe_sylius_akeneo.product.taxons_resolver" class="Webgriffe\SyliusAkeneoPlugin\Product\AlreadyExistingTaxonsResolver">
             <argument type="service" id="sylius.repository.taxon" />

diff --git a/tests/Behat/Context/Ui/Admin/ManagingProductsContext.php b/tests/Behat/Context/Ui/Admin/ManagingProductsContext.php
@@ -11,18 +11,17 @@
 use Sylius\Behat\Service\Helper\JavaScriptTestHelperInterface;
 use Sylius\Behat\Service\NotificationCheckerInterface;
 use Sylius\Component\Core\Model\ProductInterface;
-use Tests\Webgriffe\SyliusAkeneoPlugin\Behat\Page\Admin\QueueItem\IndexPageInterface as QueueItemsIndexPageInterface;
 use Webmozart\Assert\Assert;
 
 final class ManagingProductsContext implements Context
 {
     private const SCHEDULE_AKENEO_PIM_IMPORT = 'Schedule Akeneo PIM import';
 
-    /**
-     * ProductItems constructor.
-     */
-    public function __construct(private IndexPageInterface $indexPage, private JavaScriptTestHelperInterface $testHelper, private NotificationCheckerInterface $notificationChecker, private QueueItemsIndexPageInterface $queueItemsIndexPage)
-    {
+    public function __construct(
+        private IndexPageInterface $indexPage,
+        private JavaScriptTestHelperInterface $testHelper,
+        private NotificationCheckerInterface $notificationChecker
+    ) {
     }
 
     /**
@@ -63,7 +62,7 @@ public function iShouldBeNotifiedThatItHasBeenAlreadyEnqueued()
     /**
      * @Then /^I should see (\d+), not imported, items? in the Akeneo queue items list$/
      */
-    public function iShouldSeeNotImportedItemInTheAkeneoQueueItemsList(int $numberOfItems)
+    public function iShouldSeeNotImportedItemInTheAkeneoQueueItemsList(int $numberOfItems): void
     {
         $this->queueItemsIndexPage->open();
         Assert::same($this->queueItemsIndexPage->countItems(), $numberOfItems);

diff --git a/tests/Behat/Context/Ui/Admin/ManagingQueueItems.php b/tests/Behat/Context/Ui/Admin/ManagingQueueItems.php
@@ -6,13 +6,11 @@
 
 use Behat\Behat\Context\Context;
 use Sylius\Behat\Service\SharedStorageInterface;
-use Tests\Webgriffe\SyliusAkeneoPlugin\Behat\Page\Admin\QueueItem\IndexPageInterface;
-use Webgriffe\SyliusAkeneoPlugin\Entity\QueueItemInterface;
 use Webmozart\Assert\Assert;
 
 final class ManagingQueueItems implements Context
 {
-    public function __construct(private IndexPageInterface $indexPage, private SharedStorageInterface $sharedStorage)
+    public function __construct(private SharedStorageInterface $sharedStorage)
     {
     }
 

diff --git a/tests/Behat/Page/Admin/QueueItem/IndexPage.php b/tests/Behat/Page/Admin/QueueItem/IndexPage.php
diff --git a/tests/Behat/Page/Admin/QueueItem/IndexPageInterface.php b/tests/Behat/Page/Admin/QueueItem/IndexPageInterface.php
diff --git a/tests/Behat/Resources/services.xml b/tests/Behat/Resources/services.xml
@@ -47,19 +47,13 @@
         <service id="webgriffe_sylius_akeneo.behat.context.system.datetime" class="Tests\Webgriffe\SyliusAkeneoPlugin\Behat\Context\System\DateTimeContext" />
 
         <service id="webgriffe_sylius_akeneo.behat.context.ui.admin.managing_queue_items" class="Tests\Webgriffe\SyliusAkeneoPlugin\Behat\Context\Ui\Admin\ManagingQueueItems">
-            <argument type="service" id="webgriffe_sylius_akeneo.behat.page.admin.queue_item.index" />
             <argument type="service" id="sylius.behat.shared_storage" />
         </service>
 
         <service id="webgriffe_sylius_akeneo.behat.context.ui.admin.managing_products" class="Tests\Webgriffe\SyliusAkeneoPlugin\Behat\Context\Ui\Admin\ManagingProductsContext">
             <argument type="service" id="sylius.behat.page.admin.product.index" />
             <argument type="service" id="sylius.behat.java_script_test_helper" />
             <argument type="service" id="sylius.behat.notification_checker" />
-            <argument type="service" id="webgriffe_sylius_akeneo.behat.page.admin.queue_item.index" />
-        </service>
-
-        <service id="webgriffe_sylius_akeneo.behat.page.admin.queue_item.index" parent="sylius.behat.page.admin.crud.index" class="Tests\Webgriffe\SyliusAkeneoPlugin\Behat\Page\Admin\QueueItem\IndexPage" public="false">
-            <argument type="string">webgriffe_sylius_akeneo_admin_queue_item_index</argument>
         </service>
     </services>
 </container>