Fix phpstan (#123)

webgriffe · Aug 29, 2022 · 9524bff · 9524bff
1 parent a656811
commit 9524bff
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 164 deletions.
diff --git a/tests/Behat/Context/Messenger/MessengerContext.php b/tests/Behat/Context/Messenger/MessengerContext.php
diff --git a/tests/Behat/Context/Ui/Admin/ManagingProductsContext.php b/tests/Behat/Context/Ui/Admin/ManagingProductsContext.php
@@ -58,9 +58,10 @@ public function iShouldBeNotifiedThatItHasBeenSuccessfullyEnqueued(): void
     public function theProductShouldHaveAnAssociationWithProducts(
         string $code,
         ProductAssociationTypeInterface $productAssociationType,
-        ...$productsNames,
+        string ...$productsNames,
     ): void {
         $product = $this->productRepository->findOneByCode($code);
+        Assert::isInstanceOf($product, ProductInterface::class);
         $this->updateSimpleProductPage->open(['id' => $product->getId()]);
         foreach ($productsNames as $productName) {
             Assert::true(
@@ -83,6 +84,7 @@ public function theProductShouldNotHaveAnAssociationWithProduct(
         string $productName,
     ): void {
         $product = $this->productRepository->findOneByCode($code);
+        Assert::isInstanceOf($product, ProductInterface::class);
         $this->updateSimpleProductPage->open(['id' => $product->getId()]);
         Assert::false(
             $this->updateSimpleProductPage->hasAssociatedProduct($productName, $productAssociationType),

diff --git a/tests/Behat/Resources/services.xml b/tests/Behat/Resources/services.xml
@@ -31,11 +31,6 @@
             <argument type="service" id="sylius.repository.product_association_type" />
         </service>
 
-        <service id="webgriffe_sylius_akeneo.behat.context.messenger" class="Tests\Webgriffe\SyliusAkeneoPlugin\Behat\Context\Messenger\MessengerContext">
-            <argument type="service" id="messenger.transport.main"/>
-            <argument type="service" id="webgriffe_sylius_akeneo.message_handler.item_import"/>
-        </service>
-
         <service id="webgriffe_sylius_akeneo.behat.context.system.filesystem" class="Tests\Webgriffe\SyliusAkeneoPlugin\Behat\Context\System\FilesystemContext">
             <argument>%webgriffe_sylius_akeneo.temporary_directory%</argument>
             <argument>%webgriffe_sylius_akeneo.temporary_files_prefix%</argument>

diff --git a/tests/Behat/Resources/suites.yml b/tests/Behat/Resources/suites.yml
@@ -89,8 +89,6 @@ default:
 
                 - webgriffe_sylius_akeneo.behat.context.cli.import_command
 
-                - webgriffe_sylius_akeneo.behat.context.messenger
-
                 - webgriffe_sylius_akeneo.behat.context.system.filesystem
                 - webgriffe_sylius_akeneo.behat.context.system.datetime
 
@@ -110,7 +108,6 @@ default:
                 - webgriffe_sylius_akeneo.behat.context.setup.queue
 
                 - sylius.behat.context.ui.admin.managing_products
-                - webgriffe_sylius_akeneo.behat.context.messenger
                 - webgriffe_sylius_akeneo.behat.context.ui.admin.managing_products
             filters:
                 tags: "@enqueuing_products && @ui"
@@ -126,8 +123,6 @@ default:
 
                 - webgriffe_sylius_akeneo.behat.context.cli.import_command
 
-                - webgriffe_sylius_akeneo.behat.context.messenger
-
                 - webgriffe_sylius_akeneo.behat.context.system.filesystem
                 - webgriffe_sylius_akeneo.behat.context.system.datetime