Skip to content

Commit

Permalink
Apply suggested changes (#123)
Browse files Browse the repository at this point in the history
  • Loading branch information
lruozzi9 committed Aug 29, 2022
1 parent 476a90d commit b71d03a
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 68 deletions.
2 changes: 1 addition & 1 deletion features/importing_generic_items.feature
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ Feature: Importing items
And the product with code "11164822" should not have an association "Pack" with product "10597353"

@cli @ui
Scenario: Enqueuing all items for a not existent importer
Scenario: Importing all items for a not existent importer
When I import all items for a not existent importer
Then I should be notified that the importer does not exists
When I browse products
Expand Down
4 changes: 2 additions & 2 deletions tests/Behat/Context/Cli/ImportCommandContext.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ final class ImportCommandContext implements Context
{
public function __construct(
private KernelInterface $kernel,
private ImportCommand $enqueueCommand,
private ImportCommand $importCommand,
private SharedStorageInterface $sharedStorage,
) {
}
Expand Down Expand Up @@ -185,7 +185,7 @@ public function iShouldBeNotifiedThatTheImporterDoesNotExists(): void
private function getCommandTester(): CommandTester
{
$application = new Application($this->kernel);
$application->add($this->enqueueCommand);
$application->add($this->importCommand);
$command = $application->find('webgriffe:akeneo:import');

return new CommandTester($command);
Expand Down
65 changes: 0 additions & 65 deletions tests/Behat/Resources/suites.yml
Original file line number Diff line number Diff line change
Expand Up @@ -78,57 +78,6 @@ default:
filters:
tags: "@importing_generic_items && @cli && @ui"

cli_enqueuing_products:
contexts:
- sylius.behat.context.hook.doctrine_orm

- sylius.behat.context.transform.date_time

- webgriffe_sylius_akeneo.behat.context.setup.akeneo
- webgriffe_sylius_akeneo.behat.context.setup.queue

- webgriffe_sylius_akeneo.behat.context.cli.import_command

- webgriffe_sylius_akeneo.behat.context.system.filesystem
- webgriffe_sylius_akeneo.behat.context.system.datetime

filters:
tags: "@enqueuing_products && @cli"

ui_enqueuing_products:
contexts:
- sylius.behat.context.hook.doctrine_orm

- sylius.behat.context.transform.shared_storage
- sylius.behat.context.transform.product

- sylius.behat.context.setup.channel
- sylius.behat.context.setup.admin_security
- sylius.behat.context.setup.product
- webgriffe_sylius_akeneo.behat.context.setup.queue

- sylius.behat.context.ui.admin.managing_products
- webgriffe_sylius_akeneo.behat.context.ui.admin.managing_products
filters:
tags: "@enqueuing_products && @ui"

cli_enqueuing_products_associations:
contexts:
- sylius.behat.context.hook.doctrine_orm

- sylius.behat.context.transform.date_time

- webgriffe_sylius_akeneo.behat.context.setup.akeneo
- webgriffe_sylius_akeneo.behat.context.setup.queue

- webgriffe_sylius_akeneo.behat.context.cli.import_command

- webgriffe_sylius_akeneo.behat.context.system.filesystem
- webgriffe_sylius_akeneo.behat.context.system.datetime

filters:
tags: "@enqueuing_products_associations && @cli"

cli_reconcile_products:
contexts:
- sylius.behat.context.hook.doctrine_orm
Expand All @@ -148,17 +97,3 @@ default:
- webgriffe_sylius_akeneo.behat.context.cli.reconcile_command
filters:
tags: "@reconcile_products && @cli"

ui_managing_queue_items:
contexts:
- sylius.behat.context.hook.doctrine_orm

- sylius.behat.context.transform.shared_storage

- sylius.behat.context.setup.admin_security
- webgriffe_sylius_akeneo.behat.context.setup.queue

- sylius.behat.context.ui.admin.notification

filters:
tags: "@managing_queue_items && @ui"

0 comments on commit b71d03a

Please sign in to comment.