Fix psalm errors #113
Merged
Fix psalm errors #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -75,13 +97,13 @@ public function enqueueAction(int $productId): Response | |||
| foreach ($alreadyEnqueued as $code) { | |||
| $this->addFlash( | |||
| 'error', | |||
| $translator->trans('webgriffe_sylius_akeneo.ui.product_already_enqueued', ['code' => $code]) | |||
| $this->translator->trans('webgriffe_sylius_akeneo.ui.product_already_enqueued', ['code' => $code]) // @phpstan-ignore-line | |||
There was a problem hiding this comment.
The // @phpstan-ignore-line is necessary?
There was a problem hiding this comment.
For phpstan here the translator property can be null, but it is impossible because it's always instantiated.
There was a problem hiding this comment.
I supposed so. That's probably a bug on phpstan
LucaGallinari
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes will solve psalm errors in test action. One is due to the deprecation of method get inside a Controller which extends the AbstractController from Symfony. The new suggested method is to manually pass the service from the constructor of the class. So, to avoid a BC break, a new deprecation has been added.