Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Sylius 1.11 #124

Merged
merged 2 commits into from
Mar 28, 2022
Merged

Upgrade to Sylius 1.11 #124

merged 2 commits into from
Mar 28, 2022

Conversation

lruozzi9
Copy link
Member

Fixes #119

Changes proposed in this pull request:

  • Drop support for Sylius 1.9 and 1.10
  • Drop support for Symfony 4.4

@webgriffe/wg-devs what do you think about this PR :shipit:?

@lruozzi9 lruozzi9 self-assigned this Mar 14, 2022
@lruozzi9 lruozzi9 added the enhancement New feature or request label Mar 14, 2022
Copy link
Member

@LucaGallinari LucaGallinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be useful to have the source URLs of the changes (if taken from somewhere) or a few words about it in the description of the PR (if custom), about the changes that have been made, otherwise it's hard to discern their correctness, or it's a double effort to find PRs etc in the web.
I found these:

bin/create_node_symlink.php Show resolved Hide resolved
@LucaGallinari
Copy link
Member

Oh, ok. Found this: https://github.com/Sylius/PluginSkeleton/pull/321/files
Didn't see it as it has not been released yet, so the compare didn't find it.

@lruozzi9
Copy link
Member Author

Oh, ok. Found this: https://github.com/Sylius/PluginSkeleton/pull/321/files Didn't see it as it has not been released yet, so the compare didn't find it.

Yes, that PR has not been already tagged but is needed to make tests green and also to align the test/application with the Sylius 1.11 configurations.

@lruozzi9
Copy link
Member Author

It still fails on JS behat, I think that is due again to the admin icon image 🤬

@lruozzi9
Copy link
Member Author

I think this Sylius/Sylius#13753 could resolve the problem definitively, but until is not released I don't know how to fix the build 🤷‍♂️

@lruozzi9
Copy link
Member Author

Another problem is that composer does not install Sylius 1.11.2 (Sylius/PluginSkeleton#323). The problem is still present in local also with that version.

@lruozzi9 lruozzi9 merged commit 91d1ce0 into master Mar 28, 2022
@lruozzi9 lruozzi9 deleted the issue-119 branch August 9, 2023 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow for Sylius 1.11
2 participants