Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid throwing if any of the values have an applicable scope #131

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Avoid throwing if any of the values have an applicable scope #131

merged 1 commit into from
Apr 14, 2022

Conversation

lruozzi9
Copy link
Member

Avoid throwing if any of the values have an applicable scope

@lruozzi9 lruozzi9 added the bug Something isn't working label Apr 12, 2022
@lruozzi9 lruozzi9 self-assigned this Apr 12, 2022
LucaGallinari
LucaGallinari approved these changes Apr 13, 2022
View reviewed changes
Copy link
Member

@LucaGallinari LucaGallinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right!

@lruozzi9 lruozzi9 merged commit 03bedc4 into 1.13 Apr 14, 2022
@lruozzi9 lruozzi9 deleted the fix-product-property-value-handler branch April 14, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucaGallinari LucaGallinari LucaGallinari approved these changes

@mmenozzi mmenozzi Awaiting requested review from mmenozzi

Assignees

@lruozzi9 lruozzi9

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lruozzi9 @LucaGallinari