Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Akeneo value if label is not defined for a locale #135

Merged
merged 1 commit into from
Aug 3, 2022

Conversation

lruozzi9
Copy link
Member

@lruozzi9 lruozzi9 commented Jul 6, 2022

Changes proposed in this pull request:

  • Use Akeneo value if label is not defined for a locale in product option value handler

@webgriffe/wg-devs what do you think about this PR :shipit:?

@lruozzi9 lruozzi9 added the bug Something isn't working label Jul 6, 2022
@lruozzi9 lruozzi9 self-assigned this Jul 6, 2022
@LucaGallinari
Copy link
Member

With the API i cannot replicate this case. It seems to never return "null" as label value for a locale, instead it seems to never return the locale in the "labels" node.
Example: in a project with 2 locales it_IT and en_US, the "adesivo" attribute has a label value only for "it_IT" and this is the response of the "/attributes" API:

{
   ...
   "labels": {
      "it_IT": "Adesivo"
   },
   ...
}

@lruozzi9
Copy link
Member Author

With the API i cannot replicate this case. It seems to never return "null" as label value for a locale, instead it seems to never return the locale in the "labels" node. Example: in a project with 2 locales it_IT and en_US, the "adesivo" attribute has a label value only for "it_IT" and this is the response of the "/attributes" API:

{
   ...
   "labels": {
      "it_IT": "Adesivo"
   },
   ...
}

It looks different behavior depending on the version of the PIM. In the v5.0.42 it returns null, but not in the v5.0.12. We have to investigate on it on a new issue.

@lruozzi9 lruozzi9 force-pushed the use-akeneo-value-if-label-locale-is-not-defined branch from c14ca62 to 2682d0e Compare July 13, 2022 13:01
@lruozzi9 lruozzi9 merged commit 7dc1904 into 1.15 Aug 3, 2022
@lruozzi9 lruozzi9 deleted the use-akeneo-value-if-label-locale-is-not-defined branch August 3, 2022 10:12
lruozzi9 added a commit that referenced this pull request Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants