Remove duplicated queue_item resource definition #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There would be a BC anyway for all other resource related services so we remove also these BC aliases. We'll document in the changelog the BC.
mmenozzi
requested review from
LucaGallinari,
azambon,
fabianaromagnoli and
lruozzi9
|
In the end I changed my mind and removed the BC breaks. Now we'll have plugin resources registered twice with different prefixes for BC compatibility. @azambon @fabianaromagnoli @lruozzi9 @LucaGallinari I'll wait at least one approval. |
lruozzi9
approved these changes
Feb 11, 2021
This was referenced Feb 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in #36 there is a duplicated queue_item resource definition. This PR removes it.
Attention: this PR introduce BC breaks in case someone decorated/used the old services definitions with the
_pluginsuffix in the service ID. I'd merge it anyway without creating a major release.