Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 7.4 support #20

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Add PHP 7.4 support #20

merged 1 commit into from
Oct 19, 2020

Conversation

youwe-petervanderwal
Copy link
Contributor

  • Looking at the PHP 7.4 Backward Incompatible Changes and the repositories code, there is no reason to block this version
  • All PhpUnit tests run succesful in PHP 7.4
  • Running the ESB in an application (development env though) works as intended

@mmenozzi
Copy link
Member

Hi @youwe-petervanderwal,
thank you for your PR. Could you please add PHP 7.4 also to Travis CI?

@youwe-petervanderwal
Add PHP 7.4 support
82306cb 
- Looking at the PHP 7.4 Backward Incompatible Changes and the repositories code, there is no reason to block this version
- All PhpUnit tests run successful in PHP 7.4
- Running the ESB in an application (development env though) works as intended
@youwe-petervanderwal
Copy link
Contributor Author

@mmenozzi

Added to travis and passed.
Do you want me to update composer.json with "webgriffe/amp-elasticsearch": "^1.3" as well?

@mmenozzi mmenozzi merged commit c3b6e4c into webgriffe:master Oct 19, 2020
@mmenozzi
Copy link
Member

@mmenozzi

Added to travis and passed.

Thanks!

Do you want me to update composer.json with "webgriffe/amp-elasticsearch": "^1.3" as well?

No it's not needed. Composer should install only "webgriffe/amp-elasticsearch": "^1.3" automatically on PHP 7.4.

@youwe-petervanderwal
Copy link
Contributor Author

@mmenozzi Thanks! Now we can migrate to PHP 7.4 without composer hacks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmenozzi mmenozzi mmenozzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@youwe-petervanderwal @mmenozzi