Meaningful HTTP Producer responses #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Let the HTTP Producer return with 500 Internal Server error if not (all) jobs could be queued - Allow option to override response code and message for user exceptions
youwe-petervanderwal
force-pushed
the
fix/http-producer-failures
branch
from
b9474e5 to
1084783
Compare
The Combination PHP <7.4 and maglnet/composer-require-checker doesn't work with Composer 2. User Composer version 1 for PHP 7.2 and 7.3.
youwe-petervanderwal
force-pushed
the
fix/http-producer-failures
branch
from
1084783 to
7028bb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background:
When a HTTP Producer parses incoming JSON (for example) the request shouldn't return a 200 OK with message "Successfully scheduled 0 job(s) to be queued." when the sent JSON is invalid and couldn't be parsed. Instead, you want to be able to send an 400 Bad Request with a message like "Request body didn't contain a valid JSON array on key 'jobs'".
Commit: