Configure HTTP server options via parameters #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the application configure the HTTP server options (for example the bodySizeLimit) via the parameters section in esb.yml.
youwe-petervanderwal
force-pushed
the
feat/server-options
branch
from
87cb41e to
e05bdd4
Compare
The Combination PHP <7.4 and maglnet/composer-require-checker doesn't work with Composer 2. User Composer version 1 for PHP 7.2 and 7.3.
Newer versions causing errors: ECS >= 8.3: PHP Fatal error: Uncaught OutOfBoundsException: Package "symplify/easy-coding-standard" is not installed in phar:///home/youwe/Projects/webgriffe-esb/vendor/phpstan/phpstan/phpstan.phar/vendor/composer/InstalledVersions.php:1081 PhpStan >= 0.12.67: Ignored error pattern /Unable to resolve the template type .*? in call to function Amp\\call/ was not matched in reported errors. Ignored error pattern /Unable to resolve the template type .*? in instantiation of class Amp\\Producer/ was not matched in reported errors.
PhpStan: Method Webgriffe\Esb\Exception\ElasticSearch\JobNotFoundException::__construct() has parameter $code with no typehint specified.
youwe-petervanderwal
force-pushed
the
feat/server-options
branch
from
e05bdd4 to
0e93f59
Compare
| @@ -56,8 +56,8 @@ | |||
| "pda/pheanstalk": "^3.1", | |||
| "mikey179/vfsstream": "^1.6", | |||
| "amphp/artax": "^3.0", | |||
| "phpstan/phpstan": "^0.12", | |||
| "symplify/easy-coding-standard-prefixed": "^8.1" | |||
| "phpstan/phpstan": "^0.12 <=0.12.66", | |||
There was a problem hiding this comment.
I'm not really happy with this change.... But with the higher versions I ran into problems with phpstan and ecs which weren't straight forward to fix (PhpStan complaining about amphp code, ecs refusing to run at all)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the application configure the HTTP server options (for example the bodySizeLimit) via the parameters section in esb.yml.
Background: I ran into the problem that my ESB application needed to accept payloads larger than the default 128KB