Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response body could be incomplete when using debugging protocol #1325

Closed
molant opened this issue Sep 19, 2018 · 0 comments
Closed

Response body could be incomplete when using debugging protocol #1325

molant opened this issue Sep 19, 2018 · 0 comments
Assignees
@molant
Labels
area:connector priority:high type:bug

Comments

@molant
Copy link
Member

molant commented Sep 19, 2018

I first encountered this when using chrome and javascript parser. The parser would fail on large scripts. After some debugging I find out the code we are passing is sometimes truncated.

The reasons seems similar to ChromeDevTools/devtools-protocol#44

Looks like we should be waiting for Network.loadingFinished before fetching the content.

I'll work on this.
@molant molant self-assigned this Sep 19, 2018
@molant molant mentioned this issue Sep 21, 2018
Closed
2 tasks
@alrra alrra closed this as completed in ea56a95 Sep 21, 2018
alrra pushed a commit that referenced this issue Sep 25, 2018
@molant @alrra
Fix: Truncated body in some circumstances
3a43352 
To make sure the body is available, `getResponseBody` has to be called
after the `loadingFinished` event is received for the `requestId`.

- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -

Fix #1325
Close #1337
@molant molant mentioned this issue Oct 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@molant molant

Labels
area:connector priority:high type:bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: Several issues with Debugging Protocol
1 participant
@molant