Update jsdom to new API #163
Assignees
Labels
Comments
This was referenced Apr 27, 2017
Closed
alrra
pushed a commit
that referenced
this issue
Apr 27, 2017
From https://github.com/tmpvar/jsdom/blob/b2bfc3d056a5af1f8305720abd70cb1a218a9509/lib/old-api.md: " The old jsdom API, from before v10, is hard to use and understand, and has bad defaults. But for now, it still has more features than the new API introduced in v10. As such, it is still supported, until we can port over all important features (notably custom resource loading) to the new API. " - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref #163 Close #144
alrra
pushed a commit
that referenced
this issue
Apr 27, 2017
From https://github.com/tmpvar/jsdom/blob/b2bfc3d056a5af1f8305720abd70cb1a218a9509/lib/old-api.md: " The old jsdom API, from before v10, is hard to use and understand, and has bad defaults. But for now, it still has more features than the new API introduced in v10. As such, it is still supported, until we can port over all important features (notably custom resource loading) to the new API. " - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - Ref #163 Close #144
|
I have a branch with the current work in progress. |
New resource loader API is now available in Great work @sarvaje! |
This was referenced Sep 7, 2018
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
jsdom's new version has a new and shiny API 🎉
PR #144 updates to v10 but it uses the old API so #161 gets unblocked once it is merged.
We should update to the new way of doings things asap (although there seems to be a few features that are not yet supported.
Sub-tasks:
canvasorcanvas-prebuiltas a peer dependency to download the images Add canvas or canvas-prebuilt as dependency #241The text was updated successfully, but these errors were encountered: