Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor DOM utils inside hint to @hint/utils #2192

Closed
molant opened this issue Apr 9, 2019 · 1 comment · Fixed by #2218
Closed

Refactor DOM utils inside hint to @hint/utils #2192

molant opened this issue Apr 9, 2019 · 1 comment · Fixed by #2218
Assignees
@sarvaje
Labels
area:api
Milestone
1904-1

Comments

@molant
Copy link
Member

molant commented Apr 9, 2019 •
edited
Loading

These should be able to be moved through a combination of moving any types they need to @hint/utils as well. The few exceptions are:

  1. Use of HTMLElement in content-type
    • Replace with a minimal local interface
  2. Use of Engine in traverse
    • Replace with EventEmitter2

Another thing to do is to re-export the types from hint.
Also classes like HTMLDocument might be moved as well.
@molant molant added the area:api label Apr 9, 2019
@antross
Copy link
Member

antross commented Apr 9, 2019

These should be able to be moved through a combination of moving any types they need to @hint/utils as well. The few exceptions are:

  1. Use of HTMLElement in content-type
    • Replace with a minimal local interface
  2. Use of Engine in traverse
    • Replace with EventEmitter2

@sarvaje sarvaje self-assigned this Apr 11, 2019
sarvaje added a commit to sarvaje/hint that referenced this issue Apr 11, 2019
@sarvaje
Breaking: Refactor DOM utils inside hint to @hint/utils
b427d9f 
Fix webhintio#2192
@sarvaje sarvaje mentioned this issue Apr 11, 2019
Merged
4 tasks
@molant molant added this to the 1904-1 milestone Apr 12, 2019
molant pushed a commit that referenced this issue Apr 12, 2019
@molant
Breaking: Refactor DOM utils inside hint to @hint/utils
f3583a2 
Fix #2192
Close #2218
@snyk-bot snyk-bot mentioned this issue Jul 27, 2021
Open
@snyk-bot snyk-bot mentioned this issue Sep 17, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sarvaje sarvaje

Labels
area:api
Projects
None yet
Milestone
1904-1
Development

Successfully merging a pull request may close this issue.

Breaking: Refactor DOM utils inside hint to @hint/utils sarvaje/hint
3 participants
@molant @antross @sarvaje