Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release manifest-icons #3849

Open
molant opened this issue Jun 29, 2020 · 4 comments
Open

Release manifest-icons #3849

molant opened this issue Jun 29, 2020 · 4 comments

Comments

@molant
Copy link
Member

molant commented Jun 29, 2020

@sarvaje @hxlnt this hint is still not published "officially" although it seems we are using it seems to be active in different places. IIRC the missing piece was to update the documentation. Ideally we should do the badge/monochrome before we "release" it.

w3c/manifest#833 (comment)

Confirmed that Chrome does not use purpose: badge anywhere, including on the server-side infrastructure. From our perspective, we are good to rename it and change its semantics. LGTM.

@amazingcaio, thanks for catching this change!

Originally posted by @molant in #3841

@molant
Copy link
Member Author

molant commented Jun 29, 2020

There are 2 PWA hints that are not published: #2351

This one is to track manifest-icons exclusively.

@hxlnt hxlnt added this to the 2008-1 milestone Jul 24, 2020
@antross
Copy link
Member

antross commented Jul 24, 2020

This will entail removing private: true from the package.json and adding this hint to each of our default configurations (for the CLI, online scanner, browser extension, etc).

@antross antross removed this from the 2008-1 milestone Oct 30, 2020
@hxlnt
Copy link
Member

hxlnt commented Dec 4, 2020

This is blocked on #2351; I will take a look next sprint. Once the docs are updated, @sarvaje will update the package.json.

@Seirdy
Copy link

Seirdy commented Dec 20, 2020

Would be great if it could also check if the manifest icons are cache-busted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants