Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example of what an immutable cache control header might look like #1112

Closed
wants to merge 1 commit into from

Conversation

Munter
Copy link

@Munter Munter commented Jun 1, 2018

Docs: Add example of immutable cache header to error message

When seeing the below error message about far future expiring cache headers, it's not very actionable. Add an example of how to fix the error

image

@Munter Munter requested review from alrra, molant and sarvaje as code owners June 1, 2018 17:35
@alrra
Copy link
Contributor

alrra commented Jun 1, 2018

Add an example of how to fix the error

@Munter The examples are in the documentation (even how to configure some servers)

Do you feel like the documentation link is not clear enough?


Note: If you think something can be improved related to the docs, this is the file that should be changed.

@molant
Copy link
Member

molant commented Jun 4, 2018

Maybe in this case we could make the error message clearer and have 2 different messages? One for long cache assets and another for immutable.

@molant
Copy link
Member

molant commented Jun 6, 2018

BTW, the split message is tracked in #1074
Closing this PR in favor of the work in that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants