Update to jsdom v12 #1274
Closed
Update to jsdom v12 #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alrra
reviewed
Aug 28, 2018
|
This pull request depends on jsdom/jsdom#2339 and jsdom/jsdom#2349. That's why right now the link to jsdom is to my repository. |
sarvaje
force-pushed
the
jsdom-update-v12
branch
from
685029d to
53c0a0f
Compare
sarvaje
force-pushed
the
jsdom-update-v12
branch
from
53c0a0f to
cfec123
Compare
This was referenced Sep 7, 2018
Remove `@types/jsdom` to avoid typing problems.
sarvaje
force-pushed
the
jsdom-update-v12
branch
from
699ae8b to
ca14955
Compare
alrra
pushed a commit
that referenced
this pull request
Sep 22, 2018
Depending on the package manager used for the installation, different versions of `parse5` with different APIs could be installed. Until #1274 is merged, this solves that case.
alrra
pushed a commit
that referenced
this pull request
Sep 23, 2018
Depending on the package manager used for the installation, different versions of `parse5` with different APIs could be installed. Until #1274 is merged, this solves that case.
alrra
pushed a commit
that referenced
this pull request
Sep 25, 2018
Depending on the package manager used for the installation, different versions of `parse5` with different APIs could be installed. Until #1274 is merged, this commit solves the issues specified above.
alrra
force-pushed
the
master
branch
2 times, most recently
from
e1993b0 to
6c3bfae
Compare
|
Closing in favor of #1357. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)