Fix: Make npm package not include npm-shrinkwrap.json file
#1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Even though `npm` recommends:
" The recommended use-case for `npm-shrinkwrap.json`
is applications deployed through the publishing process
on the registry: for example, daemons and **command-line
tools** intended as global installs or devDependencies "
we found that this model did not work out for this project as:
" ... that would prevent end users from having control over
transitive dependency updates. "
- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
See also: https://docs.npmjs.com/files/shrinkwrap.json
alrra
force-pushed
the
npm-shrinkwrap.json
branch
from
1322b76 to
60981a1
Compare
molant
approved these changes
Sep 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Make sure you:
For non-trivial changes, please make sure you also:
Short description of the change(s)
Even though
npmrecommends:we found that this model did not work out for this project as:
See also: https://docs.npmjs.com/files/shrinkwrap.json