Fix/timeouts

packages/configuration-development/index.json

@@ -8,6 +8,7 @@
         "summary"
     ],
     "hints": {
+        "apple-touch-icons": "off",
         "axe": "error",
         "babel-config/is-valid": "error",
         "disown-opener": "error",
@@ -25,7 +26,7 @@
         "typescript-config/target": "error",
         "webpack-config/is-installed": "error",
         "webpack-config/is-valid": "error",
-        "webpack-config/module-esnext-typescript": "error",
+        "webpack-config/module-esnext-typescript": "off",
         "webpack-config/modules/false-babel": "error",
         "webpack-config/no-devtool-in-prod": "error"
     },

packages/configuration-development/package.json

@@ -15,7 +15,7 @@
     "@hint/hint-typescript-config": "^1.1.0",
     "@hint/hint-webpack-config": "^1.0.0",
     "@hint/parser-babel-config": "^1.1.0",
-    "@hint/parser-html": "^1.0.1",
+    "@hint/parser-html": "^1.0.2",
     "@hint/parser-typescript-config": "^1.1.0",
     "@hint/parser-webpack-config": "^1.0.0"
   },

packages/configuration-web-recommended/package.json

@@ -29,7 +29,7 @@
     "@hint/hint-stylesheet-limits": "^1.0.1",
     "@hint/hint-validate-set-cookie-header": "^1.0.2",
     "@hint/hint-x-content-type-options": "^1.0.3",
-    "@hint/parser-html": "^1.0.1"
+    "@hint/parser-html": "^1.0.2"
   },
   "description": "webhint's recommended hints configuration for live websites",
   "engines": {

packages/connector-chrome/package.json

@@ -7,7 +7,7 @@
     "timeout": "1m"
   },
   "dependencies": {
-    "@hint/utils-debugging-protocol-common": "^1.0.5",
+    "@hint/utils-debugging-protocol-common": "^1.0.6",
     "chrome-launcher": "^0.10.4",
     "is-ci": "^1.2.1",
     "lockfile": "^1.0.4"

packages/connector-local/package.json

@@ -12,7 +12,7 @@
   },
   "description": "hint local connector",
   "devDependencies": {
-    "@hint/parser-html": "^1.0.1",
+    "@hint/parser-html": "^1.0.2",
     "@types/chokidar": "^1.7.5",
     "@types/mock-require": "^2.0.0",
     "ava": "^0.25.0",

packages/hint/src/lib/types/jsdom-async-html.ts

@@ -63,11 +63,16 @@ export class JSDOMAsyncHTMLElement implements IAsyncHTMLElement {
     /* istanbul ignore next */
     public getLocation(): ProblemLocation {
         try {
-            const location = this._dom && this._dom.nodeLocation(this._htmlelement);
+            /*
+             * TODO: Depending on the install (yarn vs npm) we get a different version of `jsdom`
+             * that has a different version of `parse5`. This takes care of this issue but should
+             * be fixed once we migrate completely to jsdom 12 (https://github.com/webhintio/hint/pull/1274)
+             */
+            const location: any = this._dom && this._dom.nodeLocation(this._htmlelement);
 
             return location && {
-                column: location.startTag.col,
-                line: location.startTag.line - 1
+                column: location.startTag.col || location.startTag.startCol,
+                line: (location.startTag.line || location.startTag.startLine) - 1
             } || null;
         } catch (e) {
             // JSDOM throws an exception if `includeNodeLocations` wasn't set.

packages/parser-html/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 1.0.2 (September 20, 2018)
+
+## Bug fixes / Improvements
+
+* [[`537bbbbd98`](https://github.com/webhintio/hint/commit/537bbbbd98c2269d95ecda08e54aa4a086468183)] - Fix: Use JSDOM locations for elements if available (by [`Tony Ross`](https://github.com/antross)).
+
+
 # 1.0.1 (September 6, 2018)
 
 ## Bug fixes / Improvements

packages/parser-html/package.json

@@ -73,5 +73,5 @@
     "watch:test": "ava --watch",
     "watch:ts": "npm run build:ts -- --watch"
   },
-  "version": "1.0.1"
+  "version": "1.0.2"
 }

packages/utils-debugging-protocol-common/CHANGELOG.md

@@ -1,3 +1,10 @@
+# 1.0.6 (September 20, 2018)
+
+## Bug fixes / Improvements
+
+* [[`ea56a95ce4`](https://github.com/webhintio/hint/commit/ea56a95ce452c136c872dadd9c790b2cc5f9cd06)] - Fix: Several issues with the Debugging Protocol (by [`Antón Molleda`](https://github.com/molant) / see also: [`#1325`](https://github.com/webhintio/hint/issues/1325)).
+
+
 # 1.0.5 (September 20, 2018)
 
 ## Bug fixes / Improvements

packages/utils-debugging-protocol-common/package.json

@@ -1,12 +1,14 @@
 {
   "dependencies": {
     "@hint/utils-connector-tools": "^1.0.5",
+    "abab": "^2.0.0",
     "chrome-remote-interface": "^0.26.1",
     "lodash": "^4.17.11"
   },
   "description": "hint debugging protocol common functionality",
   "devDependencies": {
     "@types/lodash": "^4.14.115",
+    "chrome-remote-debug-protocol": "^1.2.20180422",
     "eslint": "^5.6.0",
     "eslint-plugin-import": "^2.14.0",
     "eslint-plugin-markdown": "^1.0.0-beta.7",
@@ -52,5 +54,5 @@
     "watch": "npm run build && npm-run-all --parallel -c watch:*",
     "watch:ts": "npm run build:ts -- --watch"
   },
-  "version": "1.0.5"
+  "version": "1.0.6"
 }

packages/utils-debugging-protocol-common/src/cdp-async-html.ts

@@ -1,3 +1,5 @@
+import { Crdp } from 'chrome-remote-debug-protocol';
+
 import { IAsyncHTMLDocument, IAsyncHTMLElement } from 'hint/dist/src/lib/types/async-html'; //eslint-disable-line
 import { debug as d } from 'hint/dist/src/lib/utils/debug';
 import { ProblemLocation } from 'hint/dist/src/lib/types';
@@ -7,7 +9,7 @@ const debug: debug.IDebugger = d(__filename);
 /** An implementation of AsyncHTMLDocument on top of the Chrome Debugging Protocol */
 export class CDPAsyncHTMLDocument implements IAsyncHTMLDocument {
     /** The DOM domain of the CDP client. */
-    private _DOM;
+    private _DOM: Crdp.DOMClient;
     /** The root element of the real DOM. */
     private _dom;
     /** A map with all the nodes accessible using `nodeId`. */
@@ -25,7 +27,7 @@ export class CDPAsyncHTMLDocument implements IAsyncHTMLDocument {
      * initially, we store them in a Map using the `nodeId` as the key so we can access to them
      * later.
      */
-    private trackNodes(root) {
+    private trackNodes(root: Crdp.DOM.Node) {
         this._nodes.set(root.nodeId, root);
         if (!root.children) {
             return;
@@ -36,7 +38,7 @@ export class CDPAsyncHTMLDocument implements IAsyncHTMLDocument {
         });
     }
 
-    private getHTMLChildren(children: Array<any>) {
+    private getHTMLChildren(children: Array<Crdp.DOM.Node>) {
         return children.find((item) => {
             return item.nodeType === 1 && item.nodeName === 'HTML';
         });
@@ -128,7 +130,7 @@ export class AsyncHTMLElement implements IAsyncHTMLElement {
     private _attributesArray: Array<{ name: string; value: string; }> = [];
     private _attributesMap: Map<string, string> = new Map();
 
-    public constructor(htmlelement, ownerDocument, DOM) {
+    public constructor(htmlelement: Crdp.DOM.Node, ownerDocument: CDPAsyncHTMLDocument, DOM: Crdp.DOMClient) {
         if (typeof htmlelement === 'number') {
             throw new Error();
         }