ref: plain js types + js esm #19
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolaj86
force-pushed
the
ref-esm-types
branch
from
62ebe7a to
093b8a9
Compare
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
coolaj86
force-pushed
the
ref-esm-types
branch
from
093b8a9 to
40ad6be
Compare
Closed
coolaj86
force-pushed
the
ref-esm-types
branch
from
40ad6be to
1b24d83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview: https://beta.webinstall.dev/
Breaking: requires an update to node v22.12+.
Just trying to root out any possible bugs contributing to webinstall/webi-installers#962
Update: I did find one bug (a typo of
libsvslibcswhen classifying gnu vs musl), but I don't think it's a good idea to fix it, as it may break things elsewhere in webi.