Page builder blocks v2 UI list page blocks

[neatbyte-vnobis]

Changes

Add Page Blocks page to Page Builder UI app

How Has This Been Tested?

Manual testing

Documentation

None

[adrians5j]

Just a couple of comments.

[adrians5j]

Can you clarify please, what is this view? Can you provide a screenshot?

[neatbyte-vnobis]

Here is a screenshot

Design link - https://miro.com/app/board/uXjVO1XGqwg=/?share_link_id=951919244316

[adrians5j]

Was about to merget this, but I noticed one thing.

@neatbyte-vnobis , should this be "Search categories" here? Maybe "Search blocks" ?

[neatbyte-vnobis]

@adrians5j
There we are searching not blocks but categories (left panel list)
But here I may be wrong...
@SvenAlHamad can you clarify?

Design (https://miro.com/app/board/uXjVO1XGqwg=/):

[SvenAlHamad]

We are searching for blocks, that’s correct.

[neatbyte-vnobis]

@SvenAlHamad @adrians5j
In such case left panel should be affected too, am I right?
So if we search for "Heading" and there are 3 categories with such blocks - we show 3 categories and only blocks containing "Heading" word.
In such case:

1. other categories are not shown
2. counter bellow categories will show number of blocks that are matching search query

I will have to rewrite quite a few things to do it:
now left and right parts of the page are more or less independent (as other similar pages aka categories)
but with such change I need to move all GraphQL queries to parent component (so left and right parts will be using a data from it)
@adrians5j maybe I am missing an easy solution here? Feel free to give me pointer.

[adrians5j]

@neatbyte-vnobis In all of our views, these search inputs are doing a search over the entity the user's currently looking at.

For example, on the pages view, pages are being searched. On the page categories view, page categories are being searched.

So, if we were to follow the above examples and wanted to stay consistent, typing into the search field would do a search against existing page blocks.

But!

Now when I look at it, I can see that this view IS a bit different than the other ones we have. Instead of just showing blocks in the list, we're showing block categories. Once clicked, the blocks are shown on the right.

And now I do think we need to think about this.

I do agree that this should search for blocks because the user will most probably want to do that (instead of searching for block categories). But I can also see that, in the provided designs, the label said SEARCH CATEGORIES, so I can understand that this might require some changes on your side @neatbyte-vnobis.

So.... what I'd do here now is.......

@SvenAlHamad - please confirm the direction into which we want to move. Do we want to leave it as-is (and save potentially some time), or do we want to revisit this now, and make the search bar do a search over blocks?

Hopefully, I didn't miss anything (like some docs), but yeah, let's first sync on what exactly we want to have here.

[SvenAlHamad]

Ok, let's leave it so it's searching blocks if that's what's currently implemented. Once we start using it a bit I think we'll have then one milestone addressing the initial feedback and some additional polishes.

[adrians5j]

@SvenAlHamad

Actually, the way it's currently implemented is that it's searching for block categories, not blocks.

Miro:

Real app:

I'd still leave it as is, so we can address it then in the MS you mentioned.

[SvenAlHamad]

Sorry, I miss typed in my previous comment. I DO understand it's searching "block categories" and I'm happy to leave it like that for now.

[adrians5j]

@neatbyte-vnobis feel free to merge this one.

Thank you!