-
Notifications
You must be signed in to change notification settings - Fork 613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cypress Tests - Batch 6 #3821
Open
Asmaloth
wants to merge
10
commits into
webiny:next
Choose a base branch
from
Asmaloth:batch-6
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Cypress Tests - Batch 6 #3821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/cypress |
Cypress E2E tests have been initiated (for more information, click here). ✨ |
adrians5j
requested changes
Jan 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good stuff with visitWebsite / replacing nanoid.
Let's tweak a couple of things though. Nothing big I'd say.
cypress-tests/cypress/support/pageBuilder/pbCreateCategoryAndBlocks.ts
Outdated
Show resolved
Hide resolved
cypress-tests/cypress/support/pageBuilder/pbCreateCategoryAndBlocks.ts
Outdated
Show resolved
Hide resolved
cypress-tests/cypress/support/pageBuilder/pbCreateCategoryAndBlocks/createHeadingBlock.ts
Show resolved
Hide resolved
cypress-tests/cypress/e2e/admin/pageBuilder/blocks/pageBlockPreview.cy.ts
Outdated
Show resolved
Hide resolved
cypress-tests/cypress/e2e/admin/pageBuilder/blocks/pageBlockPreview.cy.ts
Outdated
Show resolved
Hide resolved
cypress-tests/cypress/e2e/admin/pageBuilder/blocks/pageBlockPreview.cy.ts
Outdated
Show resolved
Hide resolved
cypress-tests/cypress/e2e/admin/pageBuilder/blocks/pageBlockPreview.cy.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
How Has This Been Tested?
Using eslint and CI checks.
Documentation
No Jira ticket currently exists but for a description of the required changes visit: https://www.notion.so/webiny/Webiny-Testing-43be8707c3df48cbbf87d06a57720faa