Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress Tests - Batch 6 #3821

Open
wants to merge 10 commits into
base: next
Choose a base branch
from
Open

Cypress Tests - Batch 6 #3821

wants to merge 10 commits into from

Conversation

Asmaloth
Copy link
Contributor

Changes

  • Created new test for validating newly created and edited blocks with headers
  • Refactored graphQL method for creating blocks so that it can now create blocks containing headers
  • Replaced all usages of nanoid as suggested here by Pavel Cypress Tests - Batch 2, 3, and 4 #3658 (comment)
  • Refactored usages of cy.visit and Cypress.env with cy.visitWebsite for better readability.

How Has This Been Tested?

Using eslint and CI checks.

Documentation

No Jira ticket currently exists but for a description of the required changes visit: https://www.notion.so/webiny/Webiny-Testing-43be8707c3df48cbbf87d06a57720faa

@adrians5j
Copy link
Member

/cypress

Copy link

Cypress E2E tests have been initiated (for more information, click here). ✨

Copy link
Member

@adrians5j adrians5j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff with visitWebsite / replacing nanoid.

Let's tweak a couple of things though. Nothing big I'd say.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants