Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc improvements #177

Merged
merged 3 commits into from
Jul 28, 2022
Merged

Misc improvements #177

merged 3 commits into from
Jul 28, 2022

Conversation

vpavic
Copy link
Contributor

@vpavic vpavic commented Jul 28, 2022

This PR contains 3 commits with minor improvements.

vpavic added 3 commits July 28, 2022 15:42
Project version appears to have been accidentaly reverted to
5.1.3-SNAPSHOT in 120331e.
The src/main/resources/webjars-requirejs.js is redundant with requirejs
config being present in pom.xml.
This commit makes popper.js an optional dependency since:

- it isn't required for using Bootstrap
- Bootstrap distribution contains bootstrap.bundle[.min].js which embeds
  popper.js any way
@jamesward jamesward merged commit f9e9bb4 into webjars:master Jul 28, 2022
@vpavic vpavic deleted the misc-improvements branch July 28, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants