Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add: events on videoPlayer #23

Merged
merged 9 commits into from
Aug 16, 2023
Merged

add: events on videoPlayer #23

merged 9 commits into from
Aug 16, 2023

Conversation

EdPrys
Copy link
Collaborator

@EdPrys EdPrys commented Jul 17, 2023

fixed: #16

add: events on VideoPlayer component

@EdPrys EdPrys assigned EdPrys and unassigned EdPrys Jul 17, 2023
@EdPrys EdPrys added the question Further information is requested label Jul 17, 2023
@EdPrys EdPrys requested a review from Security2431 July 17, 2023 10:01
@EdPrys EdPrys marked this pull request as draft July 23, 2023 16:37
@EdPrys EdPrys removed the request for review from Security2431 July 23, 2023 16:37
@EdPrys EdPrys self-assigned this Jul 23, 2023
@EdPrys EdPrys requested a review from Security2431 July 25, 2023 11:22
Security2431
Security2431 reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Security2431 Security2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few errors in browser console

Screenshot 2023-08-03 at 7 12 28 AM

Security2431
Security2431 reviewed Aug 3, 2023
View reviewed changes
Copy link
Contributor

@Security2431 Security2431 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Btw, as i may have notice, i can pick frame out of seek bar 🤔 WDYT?

@Security2431 Security2431 merged commit d9b3ff3 into main Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Security2431 Security2431 Security2431 left review comments

Assignees

@EdPrys EdPrys

Labels
question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add preview image for video player
2 participants
@EdPrys @Security2431