Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include react-router-dom as an external dep #1014

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Include react-router-dom as an external dep #1014

merged 2 commits into from
Nov 6, 2023

Conversation

ivarnakken
Copy link
Member

It is the reason the tests are failing in lego-webapp.

@ivarnakken ivarnakken added bug-fix Pull requests that fix a bug review-needed Pull requests that need review small-fix Pull requests that fix something small labels Nov 6, 2023
@ivarnakken ivarnakken requested a review from eikhr November 6, 2023 12:10
@ivarnakken ivarnakken self-assigned this Nov 6, 2023
eikhr
eikhr approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@eikhr eikhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@ivarnakken ivarnakken added the approved Pull requests that have been approved label Nov 6, 2023
@ivarnakken ivarnakken merged commit aca311e into master Nov 6, 2023
3 checks passed
@ivarnakken ivarnakken deleted the add-react-router-to-externals branch November 6, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eikhr eikhr eikhr approved these changes

Assignees

@ivarnakken ivarnakken

Labels
approved Pull requests that have been approved bug-fix Pull requests that fix a bug review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivarnakken @eikhr