Fix funny compression (ABA-827)

[PeterJFB]

For some reason, image size was determined by the crop viewport 🙃

This means cropping a large image on a small screen would create a small image (and in theory vice versa).

This will likely resolve (ABA-827), as inserting an image is no longer determined by viewport size, but original image size.

This also means uploading a large image makes it large (assuming AWS has no compression, i has no checked).

Before:

After:

[linear]

ABA-827 Fix heavy image upload compression

[ivarnakken]

I haven't tested, but this looks promising. What I don't understand is why this suddenly started happening?

Also, I believe there's compression on gallery images as well, but the image uploader for that is outside of lego-editor, which makes me suspect there might be something else causing this?

I've checked AWS, and there should be no compression on their side. Should probably investigate that further though

[eikhr]

What I don't understand is why this suddenly started happening?

I believe image size has always been related to the size of the crop viewport, but the insane compression is definitely someting new.

[eikhr]

Will this cause overflow issues if someone uploads very large images? Maybe we should have some maximum size, or maybe rather limit it in backend or just when displaying the images in the editor.

[PeterJFB]

I haven't tested, but this looks promising. What I don't understand is why this suddenly started happening?

I assume the final size used to be determined by the Image and canvas-object created when inserting the image. This means any css-changes to the page or browser-update to object defaults could affect the image quality 🙃

Also, I believe there's compression on gallery images as well, but the image uploader for that is outside of lego-editor, which makes me suspect there might be something else causing this?

Might be, I've only looked at the images which have had this issue (org-kart), and the fix looks promising.

I've checked AWS, and there should be no compression on their side. Should probably investigate that further though

Agreed. 🙌

Will this cause overflow issues if someone uploads very large images? Maybe we should have some maximum size, or maybe rather limit it in backend or just when displaying the images in the editor.

One way to find out 😉. Should be easy to see if this has to be fixed in staging

[ivarnakken]

Also, I believe there's compression on gallery images as well, but the image uploader for that is outside of lego-editor, which makes me suspect there might be something else causing this?

Might be, I've only looked at the images which have had this issue (org-kart), and the fix looks promising.

Have you looked at this?

Will this cause overflow issues if someone uploads very large images? Maybe we should have some maximum size, or maybe rather limit it in backend or just when displaying the images in the editor.

One way to find out 😉. Should be easy to see if this has to be fixed in staging

And this

[PeterJFB]

Also, I believe there's compression on gallery images as well, but the image uploader for that is outside of lego-editor, which makes me suspect there might be something else causing this?

Might be, I've only looked at the images which have had this issue (org-kart), and the fix looks promising.

Have you looked at this?

Will this cause overflow issues if someone uploads very large images? Maybe we should have some maximum size, or maybe rather limit it in backend or just when displaying the images in the editor.

One way to find out 😉. Should be easy to see if this has to be fixed in staging

And this

Merge first, check later 😎, approve pls

[ivarnakken]

Merge first, check later 😎, approve pls

what?

[eikhr]

Looks good. Definitely needs some more testing, but I think doing it in staging is ok. I think any image size limits we need to implement should be done on backend anyways.