Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable text strikethrough in editor #741

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Enable text strikethrough in editor #741

merged 1 commit into from
Feb 27, 2023

Conversation

ingraso
Copy link
Member

@ingraso ingraso commented Feb 27, 2023 •
edited
Loading

Description

As requested in this issue it is now possible to strikethrough text. One can either use the hotkey alt+shift+5 as used by Google Spreadsheets, or manually press the icon.

Result

Before
image

After
image

Testing

  • I have thoroughly tested my changes.

The changes have been tested manually both with light and dark mode. As well, the feature is added to the serializer and deserializer tests.

Resolves #739 and ABA-308

@ingraso ingraso added enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review small-fix Pull requests that fix something small labels Feb 27, 2023
@ingraso ingraso self-assigned this Feb 27, 2023
@linear
Copy link

linear bot commented Feb 27, 2023

ABA-308 Support text strikethrough in lego-editor

As described in this issue.

LudvigHz
LudvigHz previously approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@LudvigHz LudvigHz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

ivarnakken
ivarnakken previously approved these changes Feb 27, 2023
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! 💯

@ingraso ingraso dismissed stale reviews from ivarnakken and LudvigHz via fbbf1fa February 27, 2023 14:15
@ingraso
Enable text strikethrough in editor
f39edad 
As requested in the following issue:
#739

Signed-off-by: ingraso <iasolbjorg@gmail.com>
@ingraso ingraso merged commit 50661af into master Feb 27, 2023
@ingraso ingraso deleted the aba-308-text-strikethrough branch February 27, 2023 14:33
norbye added a commit that referenced this pull request Mar 15, 2023
@norbye
v2.1.0
2dfb20e 
New features
* The editor now supports strikethrough text (#741)

Fixes
* Fix paragraph overflow on long words (#765)
* Fix invisible text in link input when using dark mode (#647)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken left review comments

@LudvigHz LudvigHz LudvigHz left review comments

@eikhr eikhr Awaiting requested review from eikhr

Assignees

@ingraso ingraso

Labels
enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review small-fix Pull requests that fix something small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support text strikethrough
3 participants
@ingraso @LudvigHz @ivarnakken