Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup server side renderer #1567

Merged
merged 6 commits into from
May 13, 2019
Merged

Cleanup server side renderer #1567

merged 6 commits into from
May 13, 2019

Commits on May 11, 2019

  1. Cleanup server side renderer 

    This makes server part of webpack build way faster during development,
~10x.

Benchmark (my xps):
- OLD: 19.35s
- NEW:  1.97s
    @odinuge
    odinuge committed May 11, 2019
    Configuration menu
    Copy the full SHA
    d1576d9 View commit details
    Browse the repository at this point in the history

Commits on May 13, 2019

  1. Update react-hot-loader

    @odinuge
    odinuge committed May 13, 2019
    Configuration menu
    Copy the full SHA
    c36cf78 View commit details
    Browse the repository at this point in the history

  2. Use render instead of hydrate when not using ssr

    @odinuge
    odinuge committed May 13, 2019
    Configuration menu
    Copy the full SHA
    3857cac View commit details
    Browse the repository at this point in the history

  3. Bump webpack deps

    @odinuge
    odinuge committed May 13, 2019
    Configuration menu
    Copy the full SHA
    5711346 View commit details
    Browse the repository at this point in the history

  4. Ingore react-invalid-hook-call on SSR 

    The plain Component(props) doesn't support hooks on
ssr, so the prepare method will crash if a component
use hooks. This doesn't matter as long as we don't use hooks
before using prepare(). THen the warning can be ignored.
    @odinuge
    odinuge committed May 13, 2019
    Configuration menu
    Copy the full SHA
    d5396f7 View commit details
    Browse the repository at this point in the history

  5. Remove unused dependency parse5

    @odinuge
    odinuge committed May 13, 2019
    Configuration menu
    Copy the full SHA
    9bb4ed4 View commit details
    Browse the repository at this point in the history