Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make picture consent text shorter #5164

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Make picture consent text shorter #5164

wants to merge 1 commit into from

Conversation

jennymul
Copy link
Contributor

@jennymul jennymul commented Nov 6, 2024

Description

Make description for picture consent on events shorter

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.


Description Before After
...

image

image
image

Testing

  • I have thoroughly tested my changes.

Resolves ABA-830

@linear Linear
Copy link

linear bot commented Nov 6, 2024

ABA-830 Shorten the photo consent text on event page

@jennymul jennymul requested a review from ivarnakken November 6, 2024 19:56
@vercel Vercel
Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Nov 6, 2024 7:56pm

@github-actions github-actions bot added the review-needed Pull requests that need review label Nov 6, 2024
@jennymul jennymul self-assigned this Nov 6, 2024
norbye
norbye approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@norbye norbye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ivarnakken
ivarnakken approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!! 😍 I only need to sort the imports so that our linter is happy

@ivarnakken ivarnakken added enhancement Pull requests that make enhancements, instead of just purely new features approved Pull requests that have been approved labels Nov 7, 2024
danielyanghansen
danielyanghansen approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@danielyanghansen danielyanghansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivarnakken ivarnakken ivarnakken approved these changes

@danielyanghansen danielyanghansen danielyanghansen approved these changes

@norbye norbye norbye approved these changes

Assignees

@jennymul jennymul

Labels
approved Pull requests that have been approved enhancement Pull requests that make enhancements, instead of just purely new features review-needed Pull requests that need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jennymul @norbye @danielyanghansen @ivarnakken