-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: A new toggle button for advanced settings #5290
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job!
app/routes/users/components/UserSettings/UserSettings.module.css
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to separate this!!
app/routes/users/components/UserSettings/UserSettings.module.css
Outdated
Show resolved
Hide resolved
@@ -243,7 +250,22 @@ const UserSettings = () => { | |||
</TypedLegoForm> | |||
|
|||
{isCurrentUser && ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be wrapped in another <Flex column gap="var(--spacing-md)">
because of the spacings between all sections on this page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I implemented this in the newest PR, but I'm not sure this is implemented correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost perfect!
I realise this was very picky, and poorly explained.
Because of the Accordion we need to wrap the child element in yet another Flex component to get the correct spacing between the updating password section and delete user section. Like so:
<Flex column gap="var(--spacing-md)">
<div>
<h2>Endre passord</h2>
<ChangePassword />
</div>
<div>
<h2 className={styles.deleteUser}>Slett bruker</h2>
<DeleteUser />
</div>
</Flex>
This gives us this:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I get it. Pushed a fix, let me know if it's incorrect!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to separate this!!
Description
Added a toggle button for changing of password in settings profile. This makes the page less messy.
Result
If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.
Testing
Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.
Resolves ADA-1242