Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: A new toggle button for advanced settings #5290

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ch0rizo
Copy link
Contributor

@ch0rizo ch0rizo commented Jan 22, 2025

Description

Added a toggle button for changing of password in settings profile. This makes the page less messy.

Result

If you've made visual changes, please check the boxes below and include images showing the changes. Descriptions are appreciated.

  • Changes look good on both light and dark theme.
  • Changes look good with different viewports (mobile, tablet, etc.).
  • Changes look good with slower Internet connections.
Now a toggle button for changing of password and deletion of account Screenshot 2025-01-22 at 20 54 36 Screenshot 2025-01-22 at 20 54 11

Testing

  • I have thoroughly tested my changes.

Please describe what and how the changes have been tested, and provide instructions to reproduce if necessary.


Resolves ADA-1242

@ch0rizo ch0rizo requested a review from a team January 22, 2025 19:56
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
lego-bricks-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 26, 2025 0:47am

@github-actions github-actions bot added the review-needed Pull requests that need review label Jan 22, 2025
Copy link
Contributor

@falbru falbru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job!

Copy link
Contributor

@ShaileshS1702 ShaileshS1702 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice work

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to separate this!!

@@ -243,7 +250,22 @@ const UserSettings = () => {
</TypedLegoForm>

{isCurrentUser && (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be wrapped in another <Flex column gap="var(--spacing-md)"> because of the spacings between all sections on this page

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented this in the newest PR, but I'm not sure this is implemented correctly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost perfect!

I realise this was very picky, and poorly explained.

Because of the Accordion we need to wrap the child element in yet another Flex component to get the correct spacing between the updating password section and delete user section. Like so:

         <Flex column gap="var(--spacing-md)">
              <div>
                <h2>Endre passord</h2>
                <ChangePassword />
              </div>
              <div>
                <h2 className={styles.deleteUser}>Slett bruker</h2>
                <DeleteUser />
              </div>
            </Flex>

This gives us this:

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I get it. Pushed a fix, let me know if it's incorrect!

Copy link
Member

@ivarnakken ivarnakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to separate this!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review-needed Pull requests that need review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants