implement erf #59
Merged
implement erf #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BruceDai
reviewed
Nov 29, 2023
src/unary.js
Outdated
|
|
||
| export const erf = (input) => { | ||
| /** | ||
| *reference 1:https://en.wikipedia.org/wiki/Error_function |
There was a problem hiding this comment.
FYI, thanks.
Here we refer to an "Approximation with elementary function" with maximum error: 1.5×10−7 of Error function in Wikipedia as below figure:
and erf function of WebGL backend for TensorFlow.js.
const ERF = `
// Error function is calculated approximately with elementary function.
// See "Handbook of Mathematical Functions with Formulas,
// Graphs, and Mathematical Tables", Abramowitz and Stegun.
float p = ${backend_util.ERF_P};
float a1 = ${backend_util.ERF_A1};
float a2 = ${backend_util.ERF_A2};
float a3 = ${backend_util.ERF_A3};
float a4 = ${backend_util.ERF_A4};
float a5 = ${backend_util.ERF_A5};
float sign = sign(x);
x = abs(x);
float t = 1.0 / (1.0 + p * x);
return sign * (1.0 - (((((a5*t + a4)*t) + a3)*t + a2)*t + a1)*t*exp(-x*x));
`;
huningxin
reviewed
Nov 29, 2023
|
updated erf function in unary.js. PTAL, thanks! |
BruceDai
approved these changes
Nov 30, 2023
fdwr
approved these changes
Nov 30, 2023
src/unary.js
Outdated
| @@ -8,6 +8,8 @@ import {Tensor} from './lib/tensor.js'; | |||
| * @param {Function} unaryFunc | |||
| * @return {Tensor} | |||
| */ | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
[nit] Is it normal to insert 2 blank lines or 1?
There was a problem hiding this comment.
ok, I have deleted these two blank lines
fdwr
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@huningxin @BruceDai @fwdr @sushraja-msft PTAL, thanks.