Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the README #271

Merged
merged 3 commits into from
Sep 13, 2024
Merged

Optimize the README #271

merged 3 commits into from
Sep 13, 2024

Conversation

mingmingtasd
Copy link
Contributor

PTAL, thanks! @ibelem

@ibelem
Copy link
Contributor

ibelem commented Sep 5, 2024 •
edited
Loading

@mingmingtasd Because the requirement for GPU and NPU are different, we'd better to describe detailed requirement for CPU/GPU and NPU in following format, e.g. https://microsoft.github.io/webnn-developer-preview/install.html

WebNN Installation Guides

Running WebNN on CPU and GPU

Requirement description + GPU driver links.

  • Steps

Running WebNN on NPU

Requirement description + NPU driver links.

  • Steps

@huningxin

@mingmingtasd
Copy link
Contributor Author

@ibelem Updated as we discussed, ptal, thanks!

ibelem
ibelem approved these changes Sep 9, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
ibelem
ibelem suggested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ibelem ibelem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go to "%LOCALAPPDATA%\Microsoft\Edge SxS\User Data", check the "EdgeOnnxRuntimeDirectML\DirectML.dll" exists
"%LOCALAPPDATA%" means "C:\Users\AppData\Local"

@mingmingtasd Please fix the path issue in preview mode.

@mingmingtasd
Copy link
Contributor Author

Go to "%LOCALAPPDATA%\Microsoft\Edge SxS\User Data", check the "EdgeOnnxRuntimeDirectML\DirectML.dll" exists "%LOCALAPPDATA%" means "C:\Users\AppData\Local"

@mingmingtasd Please fix the path issue in preview mode.

Done. @ibelem

ibelem
ibelem approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@ibelem ibelem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, thanks @mingmingtasd . @huningxin PTAL

huningxin
huningxin approved these changes Sep 13, 2024
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@huningxin huningxin merged commit b083662 into webmachinelearning:master Sep 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibelem ibelem ibelem approved these changes

@huningxin huningxin huningxin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingmingtasd @ibelem @huningxin