-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keepDimensions
of reduction ops
#465
Comments
For contrast, the DirectML backend only supports the reverse,
Conversely, XNNPack should see:
|
Based on @fdwr's comment, would this be resolved by adding a non-normative note with hints to implementers? |
XNNPACK now supports keepDimensions = true for ReduceMean: google/XNNPACK@5ecf0769c54cd224bd0026fe2c |
Add a note based on @fdwr's comment: if the backend doesn't support a keepDimensions option, the implementation can insert a no-op reshape to keep or drop the reduced dimension(s) as needed. Fixes webmachinelearning#465
XNNPACK can't support keepDimensions = true for ReduceMean.
This issue was raised by @huningxin in WebNN Chromium CL review. Thanks Ningxin!
The text was updated successfully, but these errors were encountered: