Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert "If descriptor.dimensions does not exist, then descriptor defines a scalar input." from assertion to note #502

Closed
inexorabletash opened this issue Jan 10, 2024 · 0 comments · Fixed by #575
Closed

Convert "If descriptor.dimensions does not exist, then descriptor defines a scalar input." from assertion to note #502

inexorabletash opened this issue Jan 10, 2024 · 0 comments · Fixed by #575
Labels
bug operator specific

Comments

@inexorabletash
Copy link
Member

In MLGraphBuilder's input() method steps:

Assert: If descriptor.dimensions does not exist, then descriptor defines a scalar input.

This doesn't appear to be an assertion, rather it seems to be describing (non-normatively) how to interpret the descriptor.

Convert this to a note?
@inexorabletash inexorabletash mentioned this issue Feb 1, 2024
Closed
@inexorabletash inexorabletash mentioned this issue Feb 6, 2024
Merged
3 tasks
inexorabletash added a commit to inexorabletash/webnn that referenced this issue Feb 16, 2024
@inexorabletash
Bug fix: Fix MLGraphBuilder.input()'s handling of scalars. Fixes webm…
406aaec 
…achinelearning#502

MLOperandDescriptor was updated in c320472 to always have dimensions,
defaulted to an empty list for scalars. That makes the current prose
for input() incorrect. Issue webmachinelearning#502 already tracked correcting it, so
let's simplify - just change the logic for "is a scalar?" and drop the
bogus assert.
@inexorabletash inexorabletash mentioned this issue Feb 16, 2024
Merged
@fdwr fdwr closed this as completed in #575 Feb 21, 2024
fdwr added a commit that referenced this issue Feb 21, 2024
@inexorabletash @fdwr
Bug fix: Fix MLGraphBuilder.input()'s handling of scalars (#575)
6e99b01 
* Bug fix: Fix MLGraphBuilder.input()'s handling of scalars. Fixes #502

MLOperandDescriptor was updated in c320472 to always have dimensions,
defaulted to an empty list for scalars. That makes the current prose
for input() incorrect. Issue #502 already tracked correcting it, so
let's simplify - just change the logic for "is a scalar?" and drop the
bogus assert.

* Remove conditional and fix check dimensions to allow 0
* Factor byte length check into checking dimensions
* Oops, this should go too.
* type -> dataType
* (1) simplify (2) move into MLOperandDescriptor (3) link to #456
* Restore dimension check and reorder byte length to last
* Fix build for missing dimensions

---------

Co-authored-by: Dwayne Robinson <dwayner@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug operator specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bug fix: Fix MLGraphBuilder.input()'s handling of scalars inexorabletash/webnn
2 participants
@anssiko @inexorabletash