Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace MLActivation with MLRecurrentNetworkActivation #718

Merged
merged 5 commits into from
Jul 22, 2024
Merged

Replace MLActivation with MLRecurrentNetworkActivation #718

merged 5 commits into from
Jul 22, 2024

Conversation

a-sully
Copy link
Contributor

@a-sully a-sully commented Jul 8, 2024 •
edited by pr-preview bot
Loading

As proposed in #689 (comment)

An MLRecurrentNetworkActivation enum is sufficient for describing activation functions passed to recurrent operators like lstm and gru

Preview | Diff

@a-sully a-sully mentioned this pull request Jul 8, 2024
Open
4 tasks
@a-sully
Copy link
Contributor Author

a-sully commented Jul 10, 2024

@huningxin PTAL?

huningxin
huningxin approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@huningxin huningxin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

index.bs Outdated Show resolved Hide resolved
@a-sully
Copy link
Contributor Author

a-sully commented Jul 11, 2024

Please merge at your convenience (I don't have write access). Thanks!

@huningxin huningxin requested a review from fdwr July 12, 2024 03:17
@inexorabletash
Copy link
Member

inexorabletash commented Jul 17, 2024 •
edited
Loading

FYI this will need rebasing on top of dbb9d1c - f08f9f7 - mostly just deletions though. Once that's done, lint is happy.

fdwr
fdwr approved these changes Jul 18, 2024
View reviewed changes
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@a-sully
Copy link
Contributor Author

a-sully commented Jul 22, 2024

Conflicts resolved! Merge at your convenience 🙏

fdwr
fdwr reviewed Jul 22, 2024
View reviewed changes
index.bs Show resolved Hide resolved
fdwr
fdwr approved these changes Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@fdwr fdwr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@fdwr fdwr merged commit 487a992 into webmachinelearning:main Jul 22, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Jul 22, 2024
@a-sully @github-actions
Replace MLActivation with MLRecurrentNetworkActivation (#718)
8abd407 
SHA: 487a992
Reason: push, by fdwr

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@a-sully a-sully deleted the fix-689 branch July 23, 2024 12:57
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 28, 2024
@a-sully @chromium-wpt-export-bot
webnn: Replace MLActivation with MLRecurrentNetworkActivation
11fd55e 
Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
@chromium-wpt-export-bot chromium-wpt-export-bot mentioned this pull request Jul 28, 2024
Merged
aarongable pushed a commit to chromium/chromium that referenced this pull request Jul 28, 2024
@a-sully
webnn: Replace MLActivation with MLRecurrentNetworkActivation
28f67db 
Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1334041}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 28, 2024
@a-sully @chromium-wpt-export-bot
webnn: Replace MLActivation with MLRecurrentNetworkActivation
6be2ee2 
Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1334041}
chromium-wpt-export-bot pushed a commit to web-platform-tests/wpt that referenced this pull request Jul 28, 2024
@a-sully @chromium-wpt-export-bot
webnn: Replace MLActivation with MLRecurrentNetworkActivation
47b5098 
Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1334041}
huningxin added a commit to huningxin/webnn-samples that referenced this pull request Jul 29, 2024
@huningxin
Replace MLActivation with MLRecurrentNetworkActivation
e2edfe9 
According to spec change: webmachinelearning/webnn#718
@huningxin huningxin mentioned this pull request Jul 29, 2024
Merged
Honry pushed a commit to webmachinelearning/webnn-samples that referenced this pull request Jul 29, 2024
@huningxin
Replace MLActivation with MLRecurrentNetworkActivation (#266)
2b63a95 
According to spec change: webmachinelearning/webnn#718
@Elchi3 Elchi3 mentioned this pull request Jul 29, 2024
Merged
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Jul 31, 2024
@a-sully @moz-wptsync-bot
Bug 1910301 [wpt PR 47325] - webnn: Replace MLActivation with MLRecur…
dd02e72 
…rentNetworkActivation, a=testonly

Automatic update from web-platform-tests
webnn: Replace MLActivation with MLRecurrentNetworkActivation

Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try​:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1334041}

--

wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77
wpt-pr: 47325
jamienicol pushed a commit to jamienicol/gecko that referenced this pull request Aug 5, 2024
@a-sully @moz-wptsync-bot
Bug 1910301 [wpt PR 47325] - webnn: Replace MLActivation with MLRecur…
62862f5 
…rentNetworkActivation, a=testonly

Automatic update from web-platform-tests
webnn: Replace MLActivation with MLRecurrentNetworkActivation

Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try​:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1334041}

--

wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77
wpt-pr: 47325
i3roly pushed a commit to i3roly/firefox-dynasty that referenced this pull request Aug 7, 2024
@a-sully @moz-wptsync-bot
Bug 1910301 [wpt PR 47325] - webnn: Replace MLActivation with MLRecur…
895b912 
…rentNetworkActivation, a=testonly

Automatic update from web-platform-tests
webnn: Replace MLActivation with MLRecurrentNetworkActivation

Implements the changes from this spec PR:
webmachinelearning/webnn#718

Bug: 351866391
Cq-Include-Trybots: luci.chromium.try​:mac14-blink-rel,mac14.arm64-blink-rel,win11-blink-rel
Change-Id: I163c85af63468a2ad4166509196ac3734d379df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5689531
Commit-Queue: Austin Sullivan <asully@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1334041}

--

wpt-commits: 47b5098ce13c2927fe2913fb97996783c717ca77
wpt-pr: 47325
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fdwr fdwr fdwr approved these changes

@inexorabletash inexorabletash inexorabletash left review comments

@huningxin huningxin huningxin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@a-sully @inexorabletash @huningxin @fdwr