Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As a general purpose proxy, we shouldn't limit the number of connections to emulate Firefox 3. #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nirvdrum
Copy link
Contributor

I think this one is pretty safe, but I wanted another set of eyes before I blindly merged it.

@lightbody
Copy link
Member

I agree this code isn't correct, but I think the real fix is to also expose control over this behavior out via an API to BMP. Are you at all inclined to do that part too before I merge it in? :)

@nirvdrum
Copy link
Contributor Author

Are you thinking each proxy would allow its own connection limit? Or would it be a global limit across all proxies? If the latter, which likely makes the most sense, I'd rather just do it as a startup param. But I could be persuaded otherwise. I just don't want to overly complicate things and my guess is most BMP users are now Selenium users, who are going to have their limits imposed by the client or grid, more than anything else.

@lightbody
Copy link
Member

Yes, I think that we should allow the configuration on a per-proxy basis, since that's how all the other configuration is done (interceptors, bandwidth simulators, host mappings, etc). I'm also open to a "global config" concept that would apply for all configuration items, but that's kind of a separate feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants