Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

warning message if noscript or similarmenabled #930

Closed
gnadelwartz opened this issue Dec 10, 2017 · 5 comments
Closed

warning message if noscript or similarmenabled #930

gnadelwartz opened this issue Dec 10, 2017 · 5 comments

Comments

@gnadelwartz
Copy link
Contributor

gnadelwartz commented Dec 10, 2017

today i was suprised that webmin was no more working in my mobile firefox.
after some testing with older theme versions i saw that the noscript extension was enabled.

i had an exception for webmin configured, this seems to be lost when noscript uodates to the new webextension of firefox.

may be you can place a div with a hint that may be noscript or similar is active and need to be deactivated for webmin. as soon as your first javascriot is running the div can be removed.

what do you think about the idea?

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

How about some tasty notification?

screenshot from 2017-12-11 01-09-15

@gnadelwartz
Copy link
Contributor Author

looks fine ...

@iliajie
Copy link
Collaborator

iliajie commented Dec 10, 2017

Done.

Tell me how it feels?

@iliajie iliajie closed this as completed Dec 10, 2017
@gnadelwartz
Copy link
Contributor Author

with noscript enabled no warning is displayed, may be update from within webmin does not fetch the latest patch ... no same when updating from command line

noscript

@gnadelwartz
Copy link
Contributor Author

gnadelwartz commented Dec 11, 2017

i think i know why its not displayed: you used <noscript> tags, but Firefox noscript extension does not disable javascrip.

it filters out bad javascript. so browser does think it's enabled and some simple functions like onclick in a link works but not more danger option's are blocked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants