Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some mails are blank, but visible in "raw" #58

Closed
swelljoe opened this issue May 3, 2020 · 12 comments
Closed

Some mails are blank, but visible in "raw" #58

swelljoe opened this issue May 3, 2020 · 12 comments

Comments

@swelljoe
Copy link
Collaborator

swelljoe commented May 3, 2020

Some kinds of HTML email don't show up at all in the Read Mail module, though the contents can be seen with "View raw message".

An example email that exhibits this behavior: http://calport.com/open/email.txt

I don't see any clues, but I don't have any insight into the mail parser.

@jcameron
Copy link
Collaborator

jcameron commented May 3, 2020

Looks like a bug in parsing the message content. Could you forward one of these to me as an attachment, including all the headers?

@swelljoe
Copy link
Collaborator Author

swelljoe commented May 3, 2020

The one I linked above is the only one I have (though maybe I can find one in my own mailbox, since it has been reported by multiple people).

@swelljoe
Copy link
Collaborator Author

swelljoe commented May 3, 2020

I found another example in my own mailbox, and sent it to you.

webmin pushed a commit to webmin/webmin that referenced this issue May 3, 2020
@jcameron
Copy link
Collaborator

jcameron commented May 3, 2020

Looks like that example email has only HTML contents, but no text. There's an option on the preferences page that controls if the body can be shown as HTML or not .. the default is only text, which could cause this to show up as blank (at least, it did in my tests just now).

@swelljoe
Copy link
Collaborator Author

swelljoe commented May 3, 2020

So...to end users that just looks like it doesn't work. I don't know what the right thing is, but this definitely aint it! ;-)

@swelljoe
Copy link
Collaborator Author

swelljoe commented May 3, 2020

Are we concerned about dangerous content, or is there some other reason to not show HTML by default?

@swelljoe
Copy link
Collaborator Author

Is it safe to change the default on this to allow HTML? I guess we don't have mechanisms for blocking media until permitted (as Thunderbird does), so maybe tracking images are an issue...but, probably less of a problem than "email is blank".

@iliajie
Copy link
Collaborator

iliajie commented Jun 27, 2020

Is it safe to change the default on this to allow HTML?

It should be considerably safe.

I guess we don't have mechanisms for blocking media until permitted (as Thunderbird does),

We do.

image

.. so maybe tracking images are an issue...but, probably less of a problem than "email is blank".

Certainly.

2a3a1cd
virtualmin/Virtualmin-Config@2af57a5

@iliajie iliajie closed this as completed Jun 27, 2020
@jcameron
Copy link
Collaborator

I do think it's safe to allow HTML by default - I'll make that switch in the next Usermin release.

@iliajie
Copy link
Collaborator

iliajie commented Jun 27, 2020

Haven't I already done it in the commits above?

@jcameron
Copy link
Collaborator

Your commit 2a3a1cd is in the wrong files.

@iliajie
Copy link
Collaborator

iliajie commented Jun 27, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants