-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added allNullOr* and nullOrAll* methods documentation and tests #68
added allNullOr* and nullOrAll* methods documentation and tests #68
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this PR.
It is a bit hard to review with the major diff. And some changes is is just style fixes.
Could you maybe explain why you are doing these 2? 3? different changes and then make them in separate PRs?
@Nyholm ok, i'll split this PR in 2 or 3 punctual PR to make changes clearer |
@Nyholm after some investigation i preferred to split in more commits instead of more PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good.
The diff is quite unfair to you. I had some smaller issues. I will do a final check when they are ready.
@Nyholm [need-help] can't understand why AppVeyor build failed |
I think AppVeyor is unrelated. |
currently this libs allow call methods like:
Assert::allNullOrString([null, 'string']);
or
Assert::nullOrAllString(null);
Assert::nullOrAllString(['str1', 'str2']);
this PR add test coverage and method documentation to all this methods.
if community approve this PR, I provide to update
README.mb
andCHANGELOG.mb