fix: Remove hooks API deprecations #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This part of the API should not be deprecated. The idea of `ParallelCommand` is to provide a leaner and alternative API, not to replace the `Parallelization` trait. A number of configuration methods are and should remain deprecated as they can now be easily configured via `configureParallelExecutableFactory()` instead*. *: the interest here is not so much to provide a difference from a user perspective, but rather to have one central point of customization, the `ParallelExecutorFactory`. Otherwise if we add/change a setting there we need to change it both in the factory and the trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This part of the API should not be deprecated. The idea of
ParallelCommandis to provide a leaner and alternative API, not to replace theParallelizationtrait.A number of configuration methods are and should remain deprecated as they can now be easily configured via
configureParallelExecutableFactory()instead*.*: the interest here is not so much to provide a difference from a user perspective, but rather to have one central point of customization, the
ParallelExecutorFactory. Otherwise if we add/change a setting there we need to change it both in the factory and the trait.