Try using build arg for php version

webmozarts · Jan 20, 2021 · 6e026f5 · 6e026f5
1 parent 51b24e3
commit 6e026f5
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/alpine.dockerfile b/.github/workflows/alpine.dockerfile
@@ -1,2 +1,3 @@
-FROM php:8-cli-alpine
+ARG PHP_VERSION
+FROM php:{$PHP_VERSION}-cli-alpine
 COPY . .
diff --git a/.github/workflows/phpunit.yml b/.github/workflows/phpunit.yml
@@ -63,8 +63,7 @@ jobs:
 
       - name: "Build Alpine image"
         if: ${{ matrix.operating-system == 'ubuntu-latest' }}
-        # todo: image per tag
-        run: docker build --file .github/workflows/alpine.dockerfile --tag testenv .
+        run: docker build --file .github/workflows/alpine.dockerfile --build-arg=${{ matrix.php-version }} --tag testenv .
 
       - name: "Test under Alpine"
         if: ${{ matrix.operating-system == 'ubuntu-latest' }}