Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMakeLists: fix sjpeg-utils dependency #121

Merged
merged 1 commit into from
Sep 22, 2023

Conversation

jzern
Copy link
Contributor

@jzern jzern commented Sep 22, 2023

This library relies on sjpeg::EncoderParam::ResetMetadata() when
SJPEG_HAVE_JPEG or SJPEG_HAVE_PNG are set. The header is included
unconditionally, so the dependency is treated the same.

Fixes undefined reference link errors to the function.

Thanks to @leleliu008 for the report and proposed fix.

Fixes #120.

This library relies on sjpeg::EncoderParam::ResetMetadata() when
SJPEG_HAVE_JPEG or SJPEG_HAVE_PNG are set. The header is included
unconditionally, so the dependency is treated the same.

Fixes undefined reference link errors to the function.

Thanks to @leleliu008 for the report and proposed fix.

Fixes webmproject#120.
@jzern jzern requested a review from skal65535 September 22, 2023 04:53
@jzern jzern merged commit a3bd540 into webmproject:master Sep 22, 2023
4 checks passed
@jzern jzern deleted the fix-sjpeg-utils-link-120 branch September 22, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build for Android failed
2 participants