Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InitializeStaticPointers: make init thread safe #126

Merged
merged 2 commits into from
May 20, 2024

Conversation

jzern
Copy link
Contributor

@jzern jzern commented May 18, 2024

fixes TSan warnings:
Read of size 8 at 0x7f6c00f850e8 by thread T914:
#0 InitializeStaticPointers
#1 sjpeg::Encoder::Encoder(SjpegYUVMode, int, int, sjpeg::ByteSink*)
...
Previous write of size 8 at 0x7f6c00f850e8 by thread T875:
#0 InitializeStaticPointers
#1 sjpeg::Encoder::Encoder(SjpegYUVMode, int, int, sjpeg::ByteSink*)

fixes TSan warnings:
Read of size 8 at 0x7f6c00f850e8 by thread T914:
    #0 InitializeStaticPointers
    #1 sjpeg::Encoder::Encoder(SjpegYUVMode, int, int, sjpeg::ByteSink*)
...
  Previous write of size 8 at 0x7f6c00f850e8 by thread T875:
    #0 InitializeStaticPointers
    #1 sjpeg::Encoder::Encoder(SjpegYUVMode, int, int, sjpeg::ByteSink*)
@jzern jzern requested a review from skal65535 May 18, 2024 01:45
@jzern
Copy link
Contributor Author

jzern commented May 18, 2024

cc: @vigneshvg

src/enc.cc Show resolved Hide resolved
@jzern jzern merged commit 1c025b3 into webmproject:main May 20, 2024
4 checks passed
@jzern jzern deleted the init-threadsafe branch May 20, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants