-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parse more information from the RNG grammar. #913
base: master
Are you sure you want to change the base?
Conversation
Build succeeded. |
Build succeeded. |
* @return {?Element} | ||
*/ | ||
function getFirstElementNode(node) { | ||
node = node.firstChild; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a firstElementChild
and nextElementSibling
properties you might be able to use here instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are not available in the DOM implementation that WebODF uses on Node.js.
Code is good though. I really like your API dox... very clear and informative 😄 |
@peitschie Thanks for the review. I've found an error in the implementation and will update the PR once I fix that. This code is a port from Java code I'm working on. Once the Java code stabilizes, I'll update this code. |
The parser now knows which elements or attributes are allowed on elements. It also know which elements may contain text. This information is not yet output.
Build failed. |
The parser now knows which elements or attributes are allowed on elements.
It also know which elements may contain text.
This information is not yet output.