Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse more information from the RNG grammar. #913

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vandenoever
Copy link
Member

The parser now knows which elements or attributes are allowed on elements.
It also know which elements may contain text.
This information is not yet output.

@kogmbh-ci
Copy link

Build succeeded.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2407/

@kogmbh-ci
Copy link

Build succeeded.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2408/

* @return {?Element}
*/
function getFirstElementNode(node) {
node = node.firstChild;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a firstElementChild and nextElementSibling properties you might be able to use here instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are not available in the DOM implementation that WebODF uses on Node.js.

@peitschie
Copy link
Contributor

Code is good though. I really like your API dox... very clear and informative 😄

@vandenoever
Copy link
Member Author

@peitschie Thanks for the review. I've found an error in the implementation and will update the PR once I fix that. This code is a port from Java code I'm working on. Once the Java code stabilizes, I'll update this code.

The parser now knows which elements or attributes are allowed on elements.
It also know which elements may contain text.
This information is not yet output.
@kogmbh-ci
Copy link

Build failed.
Refer to this link for build results: http://ci.kogmbh.com/jenkins/job/WebODF-PullReq/2423/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants